To more closely follow the guidelines in CODING_STYLE, store the result
of xc_sched_id() in the local variable r, and the check the result of
the call in a separate statement. Change the type of the output
parameter given to xc_sched_id() from libxl_scheduler to int to match
the libxc interface.
Additionally, change the error log statement to more accurately reflect
the failure. This is the only functional change introduced by this
patch.
Suggested-by: Ian Campbell <ian.campb...@citrix.com>
Signed-off-by: Chester Lin <czy...@uwaterloo.ca>
---
Now storing the return of xc_sched_id in an int as per
On Mon, 2016-01-04 at 16:23 +0000, Ian Campbell wrote:
>Safer (and cleaner looking even if I'm wrong) would be to use a temporary
>int for the function call and turn it into an enum implicitly in the return
---
tools/libxl/libxl.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 9207621..7f28af8 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5585,10 +5585,12 @@ out:
libxl_scheduler libxl_get_scheduler(libxl_ctx *ctx)
{
- libxl_scheduler sched, ret;
+ int r, sched;
+
GC_INIT(ctx);
- if ((ret = xc_sched_id(ctx->xch, (int *)&sched)) != 0) {
- LOGE(ERROR, "getting domain info list");
+ r = xc_sched_id(ctx->xch, &sched);
+ if (r != 0) {
+ LOGE(ERROR, "getting current scheduler id");
return ERROR_FAIL;
GC_FREE;
}
--
1.9.5.msysgit.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
