On Mon, 2016-01-04 at 16:23 +0000, Ian Campbell wrote:
> On Mon, 2015-12-28 at 00:16 -0500, Joshua Otto wrote:
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > @@ -5585,10 +5585,11 @@ out:
> >
> > libxl_scheduler libxl_get_scheduler(libxl_ctx *ctx)
> > {
> > - libxl_scheduler sched, ret;
> > GC_INIT(ctx);
> > - if ((ret = xc_sched_id(ctx->xch, (int *)&sched)) != 0) {
> > - LOGE(ERROR, "getting domain info list");
> > + libxl_scheduler sched;
> > + int r = xc_sched_id(ctx->xch, (int *)&sched);
>
> Safer (and cleaner looking even if I'm wrong) would be to use a
> temporary
> int for the function call and turn it into an enum implicitly in the
> return.
>
FWIW, +1 to thisRegadrs, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
