On Tue, 2015-11-24 at 17:14 +0000, Ian Campbell wrote: > @@ -507,10 +507,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu > > *v, > > mmio_info_t *info, > > > > case GICD_ICFGR: /* SGIs */ > > goto write_ignore_32; > > - case GICD_ICFGR + 1: /* PPIs */ > > + > > + case GICD_ICFGR1: > > This should have a /* PPIs */ comment I think? > > I think I could add that on commit if you agree.
With you being away this week I decided this wasn't worth holding up 11 patches over and committed without. Instead: ----8<--------- From ae3bbd51d27ac413fc948cfd3b2d5604323c7d4c Mon Sep 17 00:00:00 2001 From: Ian Campbell <ian.campb...@citrix.com> Date: Wed, 25 Nov 2015 12:02:18 +0000 Subject: [PATCH] xen/arm: vgic-v2: Add "PPIs" comment to GICD_ICFGR1 handler To match the surrounding SPIs and SGIs comments. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- xen/arch/arm/vgic-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 2c73133..c3c6b66 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -545,7 +545,7 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info, case VREG32(GICD_ICFGR): /* SGIs */ goto write_ignore_32; - case VREG32(GICD_ICFGR1): + case VREG32(GICD_ICFGR1): /* PPIs */ /* It is implementation defined if these are writeable. We chose not */ goto write_ignore_32; -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
