On 30/10/15 19:05, Andrew Cooper wrote: > On 30/10/15 17:46, Jan Beulich wrote: >> Rather than issuing a (mostly) useless separate message, rely on >> domain_crash() providing enough data, and leverage the line number >> information it prints. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > The messages are not completely useless, and they do save a round-trip > to the debug symbols (which can be a very long RTT when dealing with > customers). > > I agree that moving the domain_crash()'s is a good idea, but can we get > away with just demoing the gprintk()s to gdprintk()s ?
Apologies - this review text was intended for "[PATCH] x86: simplify do_iret() domain crashing". I replied to the wrong email. This patch "[PATCH] x86: make compat_iret() domain crash cases distinguishable" is Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
