On 28/08/15 13:41, Julien Grall wrote: > Hi Andrew, > > On 21/08/15 18:51, Andrew Cooper wrote: >> This essentially reverts c/s 2037f2adb "x86: introduce >> alloc_vcpu_guest_context()", including the newer arm bits, but achieves >> the same end goal by using the newer vmalloc() infrastructure. > I would keep alloc_vcpu_guest_context and replace the content by > vmalloc(...). It would avoid to open-coding the allocation on the vCPU > on different places.
alloc_vcpu_guest_context() only existed because x86 used to need to do something quite cumbersome. This is no longer the case, given vmalloc() as a more general solution. Retaining alloc_vcpu_guest_context() as just think wrapper, identical on all architectures, is a bad idea as it call into a separate translation unit which cannot be optimised. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
