On Wed, Jul 22, 2015 at 10:43 AM, George Dunlap <george.dun...@eu.citrix.com> wrote: > On Tue, Jul 21, 2015 at 5:15 PM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 21.07.15 at 17:56, <roger....@citrix.com> wrote: >>> Some DOMCTLs returned non-POSIX error codes, replace them with POSIX >>> compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while >>> EUSERS is replaced with EOVERFLOW. >> >> Same here basically - I'd appreciate if we could use EINVAL only as >> a last resort error value, to make errors distinguishable. > > What would be more helpful is if you suggested an alternate error code > for the two EINVAL changes in this patch.
Sorry, I see you did suggest alternates in the other mail. I retract my complaint... > In the case of the first one, it looks like this is an "internal" > hypercall used only to do continuation of paging domctls. Guests > should never call this directly; -EINVAL seems perfectly suitable > here. But still think EINVAL is probably fine for this case. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
