Rob Hoes writes ("[PATCH RFC 5/9] libxl: introduce specific JSON error codes"): > Signed-off-by: Rob Hoes <rob.h...@citrix.com> ... > - rc = ERROR_FAIL; > + rc = ERROR_JSON_SET_CONFIG;
I think I'd rather have ERROR_USERDATA_ACCESS (see my previous comments about LOCK_FAIL) or maybe ERROR_USERDATA_READ / ERROR_USERDATA_WRITE (where LOCK is the latter). > rc = parse(gc, o, p); > if (rc) { > LOG(ERROR, "unable to convert libxl__json_object to %s. (rc=%d)", > type, rc); > - rc = ERROR_FAIL; > + rc = ERROR_JSON_PARSE_CONFIG; This error is an instance of "libxl's system-wide state has become corrupted". Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel