On Tue, 2015-03-31 at 14:00 +0100, Julien Grall wrote: > >> +static void domcreate_attach_dtdev(libxl__egc *egc, > >> + libxl__domain_create_state *dcs) > > > > I know it isn't strictly needed, but I think for consistency this > > function should take a ret and check it + propagate it via > > domcreate_complete on error, like the other ones in the call chain do. > > The other caller have the ret because they use multidev. When it's not > the case (such as domcreate_console_available), the ret parameter is not > present. > > So I'm not keen to add a new unused parameter.
OK, if it's inconsistent already no harm in another. > > Regards, > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
