>>> On 09.03.15 at 13:51, <wei.l...@citrix.com> wrote:
> @@ -759,6 +784,14 @@ long do_memory_op(unsigned long cmd,
> XEN_GUEST_HANDLE_PARAM(void) arg)
> return start_extent;
> args.domain = d;
>
> + if ( construct_memop_from_reservation(d, &reservation, &args) )
> + {
> + rcu_unlock_domain(d);
> + return start_extent;
> + }
> + args.nr_done = start_extent;
> + args.preempted = 0;
Remembering Andrew's comment on your patch introducing
construct_memop_from_reservation(), the setting of
args.domain visible in the context above should either be
moved past that call, or be used by the function instead of
passing d explicitly (in which case it is pretty clear that the
function isn't free to clobber that structure field).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
