On Mon, 2015-03-09 at 11:01 +0000, Wei Liu wrote: > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > with the rest of the file, where we return 1 on 0, rather > > than using libxl error codes. > > > > While being consistent is good I'm not very sure if we should go for 0/1 > rather than libxl error codes. > If there is a plan to switch everything in xl to use libxl error code, then just let me know, ad I'll drop this patch.
As far as I could see, there is __A__ __LOT__ of 'return 0/1' (or 'exit(1)'), and only these few libxl error code usage, so it's really inconsistent! :-) > I vaguely remember at some point we > discussed we should make xl exit code better but I don't remember the > exact details. > As I said, just let me know. Dario
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel