Re: [Xen-devel] [PATCH 05/12] arm/platform: switch to plain bool

[Julien Grall]

On 09/15/2017 10:42 AM, Wei Liu wrote:

Signed-off-by: Wei Liu <wei.l...@citrix.com>

Reviewed-by: Julien Grall <julien.gr...@arm.com>

---
  xen/arch/arm/platform.c          | 14 +++++++-------
  xen/arch/arm/platforms/exynos5.c |  4 ++--
  xen/include/asm-arm/platform.h   |  4 ++--
  3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index 0af6d57bfe..3f2989ef2b 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -28,20 +28,20 @@ extern const struct platform_desc _splatform[], 
_eplatform[];
  static const struct platform_desc *platform;

-static bool_t __init platform_is_compatible(const struct platform_desc *plat)

+static bool __init platform_is_compatible(const struct platform_desc *plat)
  {
      const char *const *compat;

if ( !plat->compatible )

-        return 0;
+        return false;

for ( compat = plat->compatible; *compat; compat++ )

      {
          if ( dt_machine_is_compatible(*compat) )
-            return 1;
+            return true;
      }

- return 0;

+    return false;
  }

void __init platform_init(void)

@@ -127,17 +127,17 @@ void platform_poweroff(void)
          platform->poweroff();
  }

-bool_t platform_has_quirk(uint32_t quirk)

+bool platform_has_quirk(uint32_t quirk)
  {
      uint32_t quirks = 0;

if ( platform && platform->quirks )

          quirks = platform->quirks();

- return !!(quirks & quirk);

+    return (quirks & quirk);
  }

-bool_t platform_device_is_blacklisted(const struct dt_device_node *node)

+bool platform_device_is_blacklisted(const struct dt_device_node *node)
  {
      const struct dt_device_match *blacklist = NULL;

diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c

index 2ae5fa66e0..01247cb6a5 100644
--- a/xen/arch/arm/platforms/exynos5.c
+++ b/xen/arch/arm/platforms/exynos5.c
@@ -27,7 +27,7 @@
  #include <asm/platform.h>
  #include <asm/io.h>

-static bool_t secure_firmware;

+static bool secure_firmware;

#define EXYNOS_ARM_CORE0_CONFIG 0x2000

  #define EXYNOS_ARM_CORE_CONFIG(_nr) (EXYNOS_ARM_CORE0_CONFIG + (0x80 * (_nr)))
@@ -108,7 +108,7 @@ static int __init exynos5_smp_init(void)
          /* Have to use sysram_ns_base_addr + 0x1c for boot address */
          compatible = "samsung,exynos4210-sysram-ns";
          sysram_offset = 0x1c;
-        secure_firmware = 1;
+        secure_firmware = true;
          printk("Running under secure firmware.\n");
      }
      else
diff --git a/xen/include/asm-arm/platform.h b/xen/include/asm-arm/platform.h
index 08010ba09b..2591d7bb03 100644
--- a/xen/include/asm-arm/platform.h
+++ b/xen/include/asm-arm/platform.h
@@ -55,8 +55,8 @@ int platform_cpu_up(int cpu);
  #endif
  void platform_reset(void);
  void platform_poweroff(void);
-bool_t platform_has_quirk(uint32_t quirk);
-bool_t platform_device_is_blacklisted(const struct dt_device_node *node);
+bool platform_has_quirk(uint32_t quirk);
+bool platform_device_is_blacklisted(const struct dt_device_node *node);

#define PLATFORM_START(_name, _namestr) \

  static const struct platform_desc  __plat_desc_##_name __used   \

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel