On 07/06/17 12:19, Andrew Cooper wrote:
On 26/05/17 12:14, Punit Agrawal wrote:@@ -211,7 +221,6 @@ static void populate_physmap(struct memop_args *a) } mfn = gpfn; - page = mfn_to_page(mfn);What is the purpose of this hunk? It is not mentioned in the commit message at all, and looks unsafe to me.
Not answering why it has been dropped (leave Punit to answer this), I introduced this page = mfn_to_page(...) to match the else part of ( is_domain_direct_mapped). In the else, 'page' will always point to first base page.
However, today, nobody is using 'page' after. Unless there is a reason to drop it, I would prefer to keep it so the if and else part match.
Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
