"Jan Beulich" <jbeul...@suse.com> writes:
>>>> On 26.05.17 at 13:14, <punit.agra...@arm.com> wrote:
>> --- a/xen/include/asm-x86/page.h
>> +++ b/xen/include/asm-x86/page.h
>> @@ -375,6 +375,14 @@ perms_strictly_increased(uint32_t old_flags, uint32_t
>> new_flags)
>>
>> #define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK)
>>
>> +static inline void invalidate_icache(void)
>> +{
>> +/*
>> + * There is nothing to be done here as icaches are sufficiently
>> + * coherent on x86.
>> + */
>> +}
>
> According to osstest this change hasn't been build tested on x86:
>
> /home/osstest/build.110052.build-amd64/xen/xen/include/asm/page.h: Assembler
> messages:
> /home/osstest/build.110052.build-amd64/xen/xen/include/asm/page.h:378: Error:
> no such instruction: `static inline void invalidate_icache(void)'
> /home/osstest/build.110052.build-amd64/xen/xen/include/asm/page.h:379: Error:
> junk at end of line, first unrecognized character is `{'
> /home/osstest/build.110052.build-amd64/xen/xen/include/asm/page.h:384: Error:
> junk at end of line, first unrecognized character is `}'
> /home/osstest/build.110052.build-amd64/xen/xen/Rules.mk:177: recipe for
> target 'head.o' failed
> make[4]: Leaving directory
> '/home/osstest/build.110052.build-amd64/xen/xen/arch/x86/boot'
> make[4]: *** [head.o] Error 1
Apologies for the breakage. The above hunk needs to move into the
!__ASSEMBLY__ block.
I'll send a fix shortly.
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
