The spinlock in kexec_swap_images() was removed as
this function is only reachable on the kexec hypercall, which is
now protected at the top-level in do_kexec_op_internal(),
thus the local spinlock is no longer necessary.
Signed-off-by: Eric DeVolder <eric.devol...@oracle.com>
Reviewed-by: Bhavesh Davda <bhavesh.da...@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
---
xen/common/kexec.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 3f96eb2..efecf60 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -820,7 +820,6 @@ static int kexec_exec(XEN_GUEST_HANDLE_PARAM(void) uarg)
static int kexec_swap_images(int type, struct kexec_image *new,
struct kexec_image **old)
{
- static DEFINE_SPINLOCK(kexec_lock);
int base, bit, pos;
int new_slot, old_slot;
@@ -832,8 +831,6 @@ static int kexec_swap_images(int type, struct kexec_image
*new,
if ( kexec_load_get_bits(type, &base, &bit) )
return -EINVAL;
- spin_lock(&kexec_lock);
-
pos = (test_bit(bit, &kexec_flags) != 0);
old_slot = base + pos;
new_slot = base + !pos;
@@ -846,8 +843,6 @@ static int kexec_swap_images(int type, struct kexec_image
*new,
clear_bit(old_slot, &kexec_flags);
*old = kexec_image[old_slot];
- spin_unlock(&kexec_lock);
-
return 0;
}
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
