Wei Liu writes ("[PATCH 1/3] libxl, xl: don't init/dispose when not necessary"):
> Functions like libxl__device_disk_from_xs_be and
> libxl_vdev_to_device_disk should not touch the disk struct passed in.
> It's caller's responsibility to do that.
...
> Note that libxl_vdev_to_device_disk is a public API so a macro is
> defined in libxl.h to indicate the change of behaviour.I don't think this is really on, in the public API. Why not make libxl_..._free idempotent ? Then extra calls to _init are harmless. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
