On Wed, 2014-12-10 at 13:50 +0000, Wei Liu wrote: > On Wed, Dec 10, 2014 at 01:47:06PM +0000, Ian Campbell wrote: > > On Wed, 2014-12-10 at 13:41 +0000, Wei Liu wrote: > > > On Wed, Dec 10, 2014 at 12:54:05PM +0000, Ian Campbell wrote: > > > > #690538 relates to providing an option to remove the submenus. Please > > > > can the changelog explain why that is relevant to us. > > > > > > > > > > Because somebody else thought not making submenu optional is a bug. So > > > do I. > > > > I meant: why is this important to osstest? does using submenus break > > something? if so then what? if not then there is no reason to be > > diverging from the baseline. > > > > Submenu breaks OSSTest's grub menu parser, causing test step to fail.
Great, that's a good reason to diverge, but please say it somewhere like in the commit log. I think the parser should also gain a comment with a reference to either the bug or this discussion saying that it relies on grub not using submenus. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
