On Wed, Dec 10, 2014 at 01:47:06PM +0000, Ian Campbell wrote: > On Wed, 2014-12-10 at 13:41 +0000, Wei Liu wrote: > > On Wed, Dec 10, 2014 at 12:54:05PM +0000, Ian Campbell wrote: > > > #690538 relates to providing an option to remove the submenus. Please > > > can the changelog explain why that is relevant to us. > > > > > > > Because somebody else thought not making submenu optional is a bug. So > > do I. > > I meant: why is this important to osstest? does using submenus break > something? if so then what? if not then there is no reason to be > diverging from the baseline. >
Submenu breaks OSSTest's grub menu parser, causing test step to fail. > > > Did you fix it by removing/reverting the submenu support altogether, as > > > opposed to e.g. importing the patch from Eric Fischer in the bug report? > > > I don't see stuff which I'd expect if you had applied the patch. I think > > > it would be worth spelling out in a bit more detail what the changes > > > you've made to the baseline for each bug were. > > > > > > > I fixed this by supplying a 20_linux_xen extracted from wheezy with > > submenu generation removed (2 lines). This is how we dealt with other > > grub bugs. > > I think precisely what you've changed from the baseline should be > documented somewhere. > OK. Wei. > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
