On 2014/12/9 18:22, Jan Beulich wrote:
On 09.12.14 at 11:11, <t...@xen.org> wrote:
At 08:19 +0000 on 09 Dec (1418109561), Jan Beulich wrote:
Why do you always pick other than the simplest possible solution?
Jan, please don't make personal comments like this in code review. It
can only offend and demoralize contributors, and deter other people
from joining in.
I apologize - I shouldn't have permitted myself to do so.
I understand that it can be frustrating, and I'm sure I have lashed
Actually myself also have this same feeling but this really isn't
helpful to step forward.
out at people on-list in the past. But remember that people who are
new to the project need time to learn, and keep the comments to the
code itself.
I can see that this series has been going for a long time, and is
still getting hung up on coding style issues. Might it be useful to
Something is my fault here. Although I learn more about Xen from this
series constantly, looks its hard to cover this big thread with that
reasonable code under Xen circumstance. This is also why I claimed I
can't do this right from the start.
And additionally, even some initial designs are not very clear or argued
between us, so when we discuss something during each revision, it bring
a new thought again...
have a round of internal review from some of the more xen-experienced
engineers at Intel before Jan looks at it again?
I've been suggesting something along those lines a number of times,
with (apparently) no success at all.
Actually we had a little bit discussion internal and some guys really
brought me some comments previously, but I think they're too busy to
review each patch carefully one line by one line, especially if I bring
something new to address yours comments just in the process of public
review.
Anyway, now let me ask if this can deliver to other suitable guy. As I
said previously I really would like to quit if this can step next properly.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
