Hi Gary,
2010/5/19 sdfkjsjlh sdbfgsfsdg <sdfkjsjlhsdbfgsf...@yahoo.com>: > I took the liberty of moving the header lines to header.inc. I've also added > the new writeScreenshotLink() to compwebsite.inc but I haven't enabled it as > I didn't want to change the web site's functionality without your knowledge. I've tested and enabled it; it works just fine, thanks. Btw if you want to suggest changes to wxCode website you're encouraged to created patches and post them on this mailing list rather than directly modifying the files on the webserver. > I put it immediately under the existing version and you just need to rename > it when you're ready. I've tested everything against the mmwx site, > including the temporarily renamed new version of writeScreenshotLink(), and > haven't seen any problems. The original files are backed up as > <filename>.bak. > I moved Slimbox's css and js folders to the site root. That way we only need > the one copy for both purposes. I think it's better to place both .css and .js files in the root folder as other .css and .js files are placed there so I've moved slimbox files out of css and js folders. I also moved the gifs in the "images" folder, which I think is more appropriate. Could you please remove the "js" and "css" folders since they have no group write permission? Please remember to always adjust permissions (adding the group-write bit) of folders/files you place in "screenshots" folder or anywhere else in the wxCode website. > I'm happy to go through and put the screenshot index into the other > directories, if you'd like. I think this should be done by other maintainers, if they're interested... > Users still need to set $compname in index.php. We can remove that > requirement but it will require changing some code. I played around with > that for a while and can see most of what needs to be done but it gets hard > to debug and see what's going on when you don't have the whole site and it's > DB to work with. Basically, you'd need to change queryres_table() in > dboutput.inc to add the query string "?name=$comp[name]" to > $compurl['website'] and $compurl['screenshots']. We could then adjust the > index.php files to use the name passed. Doing that for $compurl['website'] > causes problems for file checking in write_helper_link(), though, so it > needs a bit more investigation. I think it's really easy for any maintainer to setup his lightbox-enabled screenshots page if he wants to, so I'd avoid modifying the existing code just to avoid users to modify the PHP file they put in their screenshots folder.. Forcing maintainers to open that index.php also makes them more aware of the possibilities they have and aware of how the website work ;) Thanks! Francesco ------------------------------------------------------------------------------ _______________________________________________ wxCode-users mailing list wxCode-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wxcode-users
