________________________________
I see that there's currently a big comment block on
screenshots/mmwx/index.php... I think it would be nice to put the
"js", the "css" and the index.php file (without that commented block)
in the other subfolders of wxcode/htdocs/screenshots... is it ok for
you?
-----

My apologies, I found what you were referring to and removed it.


Even better, instead of duplicating the "js" and "css" folders for
every component with screenshots, it would probably be better to put a
single copy into "screenshots" folder and then use ../js/slimbox2.js
and ../css/slimbox2.css to reference to them...
-----------

I took the liberty of moving the header lines to header.inc. I've also added 
the new writeScreenshotLink() to compwebsite.inc but I haven't enabled it as I 
didn't want to change the web site's functionality without your knowledge. I 
put it immediately under the existing version and you just need to rename it 
when you're ready. I've tested everything against the mmwx site, including the 
temporarily renamed new version of writeScreenshotLink(), and haven't seen any 
problems. The original files are backed up as <filename>.bak.
I moved Slimbox's css and js folders to the site root. That way we only need 
the one copy for both purposes.

I'm happy to go through and put the screenshot index into the other 
directories, if you'd like.

Users still need to set $compname in index.php. We can remove that requirement 
but it will require changing some code. I played around with that for a while 
and can see most of what needs to be done but it gets hard to debug and see 
what's going on when you don't have the whole site and it's DB to work with. 
Basically, you'd need to change queryres_table() in dboutput.inc to add the 
query string "?name=$comp[name]" to $compurl['website'] and 
$compurl['screenshots']. We could then adjust the index.php files to use the 
name passed. Doing that for $compurl['website'] causes problems for file 
checking in write_helper_link(), though, so it needs a bit more investigation.

Enjoy.


      
------------------------------------------------------------------------------

_______________________________________________
wxCode-users mailing list
wxCode-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wxcode-users

Reply via email to