Hi,

Kurosu a écrit :
> Hello,
>
> as for any potentially controversial commit, I'd like to first consult
> people about this feature. More precisely, this would be for the
> free-beer-ly available version ("Express") of Visual Studio 2005.
>
> It is mostly trying to work around what is missing and what is defined
> elsewhere. The patch is somewhat intrusive, but I tried to move some of
> it to tool/math_tools.{cpp,h}
>
> Currently, the open topics in my opinion about this patch are:
> - are round/lround (defined in C99 but not sure about C++) needed?
>   Wouldn't floor be sufficient in most cases ?
>   

 From the manpage of round:
CONFORMING TO
       C99.

So as C++ has been defined before C99, it should not define it. However, 
it compiles perfectly with gcc and we already use C99-only functions 
such as isnan.

> - fix for isnan is still temporary as:
>   . NaN has this particularity that NaN != NaN afaik
>   . I haven't investigated the real support for it (some say to look in
>     std::numeric_limits in float.h)
>
> The integer typedefs are a bit ugly but they seem at the right place in
> app/base.h
>
> If there's interest in it (after all, this has already brought some
> clean-up and a bug detection), I'll also contribute a project file
> (somewhat the equivalent of makefiles).
>   

I think that there could be an interest to have more developers. Of 
course, we need to be careful, our main target is gcc compiler and Unix 
systems.

Regards,

Matt (gentildemon)


_______________________________________________
Wormux-dev mailing list
Wormux-dev@gna.org
https://mail.gna.org/listinfo/wormux-dev

Répondre à