>> I'm pretty sure you can post on the bugtracker without registering.
>>
>
> No I can't.
:-/
In that case, we should think about an easiest way for user to report bugs
> So I registered, as I think I've fixed the SDL fullscreen bug.
>
great :) You think only ? Don't you have tested it ?
> Definitively. Another reason why I didn't want write access is that I
> wanted patch review. Most changes in wormux are not benign, and affect
> lots of parts in the code base.
>
Ok, I understood, the problem is that somebody needs time to review the
patch and if it's a huge patch...
But, yes, sometimes it's better than to have big regression in the code.
If we want to avoid such problem, we need more testers of the svn
version or to have weekly/monthly "release" that can be widely tested.
>
>>>>> Second, Polygon is also already defined by the windows GDI API. This
>>>>>
> [...]
>
>> :-(
>>
>
> The patch attached to the previous mail is good to go, I think. I think
> code is even cleaner that way: no need to (recursively) include tens of
> headers.
>
You're right.
> std::isnan is troublesome.
>
> The src/network/distant_cpu.h enum would gain from a more explicit name,
> at the same time solving the clash with the win API.
>
It has been fixed by lodesi if I have followed correctly
> I guess the installer changes are hard to review, except for the one
> (deki?) that provided the most recent installers through cross-compilation.
>
>
>> I'm not sure that anybody will accept to spend to time to change the
>> makefile or the autogen.sh file, but you're right, there's something to
>> do, at least for Windows and Apple systems...
>>
>
> Is the Apple maintainer active? This should be looked into with his help.
>
Yes, the (or a ?) Apple maintainer is active. He was connected to IRC
Saturday morning. Unfortunately, I don't remember his name. It seems
that for Apple, isnan is not available but NAN constant is. So 2
solutions work. The first one is to define int isnan(int a) {return (a
== NAN);}between #ifdef __APPLE__. It makes it compile but I'm not sure
definition of isnan is the good one. Second solution is to force
compiler to accept C99 functions, but for this, we need someone who is
able to modify the autogen.sh ;-)
Matt (gentildemon)
_______________________________________________
Wormux-dev mailing list
Wormux-dev@gna.org
https://mail.gna.org/listinfo/wormux-dev
