-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kyle wrote: >> >> >> This could mean 2 things: >> a) either the coder expected that the count value will always be 2, that >> means that "nbr_ammo" will always be 2 >> b) or the coder thought that "nbr_ammo" will always need the plural and >> though the way to make that happen is to assure that the count is for >> plural >> by thinking in an English centric way and how plural is formed in >> English. >> >> >> > This could also mean: > c) I blindly copied and pasted the old text into the new code, and didn't > know what the number 2 meant. It was my assumption that the 2 meant how > many > different versions of the text where in the function call (1 singular, 1 > plural). Looking back, I guess it was from the hard coded value of 2 > weapons that were handed out per box. This is my fault.
relax man, this was NOT about pinning down people, but was about raising awareness about good practices wrt i18n ;-). > gettext("%s team already has infinite ammo for the %s!") > As for this bit, it is / was there for debugging, but now this is issue is > fixed. If people wish for it to remain that might be good, since there is > checking code for an infinite ammo weapon, however, nobody should ever get > that case unless the code is changed. Again, this is my fault :-( I see. I saw the comment above, but wouldn't an assertion be more appropriate here? Also a message that could be something like: "Unexpected infinite ammo for weapon %s. Please contact wormux-dev@gna.org about this issue." Also note that you can "talk" to translator by placing comments right above the line that uses gettext and those comments will appear as an automated comment (as they are called) in the translations. This can be useful to provide context, warn translators about various things ;-) and whatnot. - -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFF1Uq0Y8Chqv3NRNoRAmogAKDChLIsN3pgC+eQvZj4g3g/h7PKhwCfeUDC fBVfuGuwBI09rE7KBGamVZM= =zDD7 -----END PGP SIGNATURE----- _______________________________________________ Wormux-dev mailing list Wormux-dev@gna.org https://mail.gna.org/listinfo/wormux-dev