Don't you need an = in the substitution value? <Substitution Table="CustomAction" Row="setFoo" Column="Target" Value="[=fooProperty]"/>
It's been a long time since I did this (http://wyrdfish.wordpress.com/2011/01/05/configurable-merge-modules/) so I may be wrong. -----Original Message----- From: TimM [mailto:timmay...@smarttech.com] Sent: 18 June 2013 23:00 To: wix-users@lists.sourceforge.net Subject: Re: [WiX-users] Passing properties to merge modules Okay I am trying this out and I can not seem to get it working. We are using WiX 3.7 and all it seems to do is delete the property. Maybe I am missing something really easy and it is just escaping me. Here is what I have: In Merge Module: <Property Id="FOO" Value="0" /> <Configuration Name="fooProperty" Format="Integer" DefaultValue="[FOO]"/> <Substitution Table="CustomAction" Row="setFoo" Column="Target" Value="[fooProperty]"/> <CustomAction Id="setFoo" Property="FOO" Value="[FOO]" Execute="immediate" /> <InstallExecuteSequence> <Custom Action="setFoo" After="CostInitialize" /> </InstallExecuteSequence> In Parent project: <DirectoryRef Id="INSTALLDIR"> <Merge Id="CoreSharedDrivers" Language="1033" SourceFile="$(var.PROJECT_ROOT)/installs/x86/$(var.Configuration)/CoreSharedD rivers.msm" DiskId="1"> <ConfigurationData Name="fooProperty" Value="[FOO]"/> </Merge> </DirectoryRef> The main differences are I am using DirectoryRef, formatting to Interger, and the property is not initially defaulted to a value in the parent install, it is only valid if passed on command line.. Here is bits of the install log: MSI (s) (BC:B8) [15:46:28:947]: Command Line: FOO=1 CURRENTDIRECTORY=c:\Users\timm\Desktop CLIENTUILEVEL=2 CLIENTPROCESSID=3856 MSI (s) (BC:B8) [15:46:29:072]: PROPERTY CHANGE: Adding FOO property. Its value is '1'. MSI (s) (BC:B8) [15:46:43:431]: Doing action: Set_FOO Action start 15:46:43: Set_FOO. Action ended 15:46:43: Set_FOO. Return value 1. MSI (s) (BC:B8) [15:46:43:603]: Doing action: setFoo.F5F26EB0_E10F_4C42_9337_E3138BE966BC MSI (s) (BC:B8) [15:46:43:603]: *PROPERTY CHANGE: Deleting FOO.F5F26EB0_E10F_4C42_9337_E3138BE966BC property. Its current value is '0'.* Action start 15:46:43: setFoo.F5F26EB0_E10F_4C42_9337_E3138BE966BC. Action ended 15:46:43: setFoo.F5F26EB0_E10F_4C42_9337_E3138BE966BC. Return value 1. Property(S): FOO = 1 So if you can see what I might be doing wrong I would appreciate finding out... Thanks, Tim. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Passing-propert ies-to-merge-modules-tp5417112p7586685.html Sent from the wix-users mailing list archive at Nabble.com. ----------------------------------------------------------------------------- - This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users SDL PLC confidential, all rights reserved. If you are not the intended recipient of this mail SDL requests and requires that you delete it without acting upon or copying any of its contents, and we further request that you advise us. SDL PLC is a public limited company registered in England and Wales. Registered number: 02675207. Registered address: Globe House, Clivemont Road, Maidenhead, Berkshire SL6 7DY, UK. ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
