I see I wasn't clear about WiXProductVersion before. I wish I had the ability to edit email that was already sent... Anyways...
WiXProductVersion doesn't have a value on the candle command line because $(WiXVersion) was not defined in my project file. I assume that WiXVersion is defined in your project file. Edwin G. Castro Software Developer - Staff Electronic Banking Services Fiserv Office: 503-746-0643 Fax: 503-617-0291 www.fiserv.com Please consider the environment before printing this e-mail > -----Original Message----- > From: Castro, Edwin G. (Hillsboro) [mailto:edwin.cas...@fiserv.com] > Sent: Wednesday, May 19, 2010 11:29 AM > To: General discussion for Windows Installer XML toolset. > Subject: Re: [WiX-users] msbuild command line parameters > > Caveat: I don't have a TFS environment to test this out on. > > I created a new WixProject and defined a couple of values in DefineConstants > like so: > > <Project DefaultTargets="Build" > xmlns="http://schemas.microsoft.com/developer/msbuild/2003";> > <PropertyGroup> > <Configuration Condition=" '$(Configuration)' == '' > ">Debug</Configuration> > <Platform Condition=" '$(Platform)' == '' ">x86</Platform> > <ProductVersion>3.0</ProductVersion> > <ProjectGuid>{c6e8cf0f-4441-4b31-92a6-d9b294adf40f}</ProjectGuid> > <SchemaVersion>2.0</SchemaVersion> > <OutputName>WixProject1</OutputName> > <OutputType>Package</OutputType> > <WixTargetsPath Condition=" '$(WixTargetsPath)' == '' AND > '$(MSBuildExtensionsPath32)' != '' > ">$(MSBuildExtensionsPath32)\Microsoft\WiX\v3.0\Wix.targets</WixTargetsPath> > <WixTargetsPath Condition=" '$(WixTargetsPath)' == '' > ">$(MSBuildExtensionsPath)\Microsoft\WiX\v3.0\Wix.targets</WixTargetsPath> > </PropertyGroup> > <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' "> > <OutputPath>bin\$(Configuration)\</OutputPath> > <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath> > <DefineConstants>Debug;WixProductName=BeamGage > Standard;WiXProductVersion=$(WiXVersion)</DefineConstants> > </PropertyGroup> > <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x86' > "> > <OutputPath>bin\$(Configuration)\</OutputPath> > <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath> > <DefineConstants>WixProductName=BeamGage > Standard;WiXProductVersion=$(WiXVersion)</DefineConstants> > </PropertyGroup> > <ItemGroup> > <Compile Include="Product.wxs" /> > </ItemGroup> > <Import Project="$(WixTargetsPath)" /> > <!-- > To modify your build process, add your task inside one of the targets > below and uncomment it. > Other similar extension points exist, see Wix.targets. > <Target Name="BeforeBuild"> > </Target> > <Target Name="AfterBuild"> > </Target> > --> > </Project> > > I now tried to build in the IDE: > > ------ Rebuild All started: Project: WixProject1, Configuration: Debug x86 --- > --- > C:\Program Files\Windows Installer XML v3\bin\candle.exe - > dDebug -d"WixProductName=BeamGage Standard" -dWiXProductVersion= - > d"DevEnvDir=C:\Program Files\Microsoft Visual Studio 9.0\Common7\IDE\\" - > dSolutionDir=C:\code\WixProject1\ -dSolutionExt=.sln - > dSolutionFileName=WixProject1.sln -dSolutionName=WixProject1 - > dSolutionPath=C:\code\WixProject1\WixProject1.sln -dConfiguration=Debug - > dOutDir=bin\Debug\ -dPlatform=x86 - > dProjectDir=C:\code\WixProject1\WixProject1\ -dProjectExt=.wixproj - > dProjectFileName=WixProject1.wixproj -dProjectName=WixProject1 - > dProjectPath=C:\code\WixProject1\WixProject1\WixProject1.wixproj - > dTargetDir=C:\code\WixProject1\WixProject1\bin\Debug\ -dTargetExt=.msi - > dTargetFileName=WixProject1.msi -dTargetName=WixProject1 - > dTargetPath=C:\code\WixProject1\WixProject1\bin\Debug\WixProject1.msi -out > obj\Debug\Product.wixobj -arch x86 Product.wxs > C:\Program Files\Windows Installer XML v3\bin\Light.exe - > cultures:null -out C:\code\WixProject1\WixProject1\bin\Debug\WixProject1.msi - > pdbout C:\code\WixProject1\WixProject1\bin\Debug\WixProject1.wixpdb > obj\Debug\Product.wixobj > C:\code\WixProject1\WixProject1\Product.wxs(6,0): warning LGHT1079: The > cabinet 'media1.cab' does not contain any files. If this installation > contains no files, this warning can likely be safely ignored. Otherwise, > please add files to the cabinet or remove it. > ========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ========== > > ------ Rebuild All started: Project: WixProject1, Configuration: Release x86 - > ----- > C:\Program Files\Windows Installer XML v3\bin\candle.exe - > d"WixProductName=BeamGage Standard" -dWiXProductVersion= - > d"DevEnvDir=C:\Program Files\Microsoft Visual Studio 9.0\Common7\IDE\\" - > dSolutionDir=C:\code\WixProject1\ -dSolutionExt=.sln - > dSolutionFileName=WixProject1.sln -dSolutionName=WixProject1 - > dSolutionPath=C:\code\WixProject1\WixProject1.sln -dConfiguration=Release - > dOutDir=bin\Release\ -dPlatform=x86 - > dProjectDir=C:\code\WixProject1\WixProject1\ -dProjectExt=.wixproj - > dProjectFileName=WixProject1.wixproj -dProjectName=WixProject1 - > dProjectPath=C:\code\WixProject1\WixProject1\WixProject1.wixproj - > dTargetDir=C:\code\WixProject1\WixProject1\bin\Release\ -dTargetExt=.msi - > dTargetFileName=WixProject1.msi -dTargetName=WixProject1 - > dTargetPath=C:\code\WixProject1\WixProject1\bin\Release\WixProject1.msi -out > obj\Release\Product.wixobj -arch x86 Product.wxs > C:\Program Files\Windows Installer XML v3\bin\Light.exe - > cultures:null -out C:\code\WixProject1\WixProject1\bin\Release\WixProject1.msi > -pdbout C:\code\WixProject1\WixProject1\bin\Release\WixProject1.wixpdb > obj\Release\Product.wixobj > C:\code\WixProject1\WixProject1\Product.wxs(6,0): warning LGHT1079: The > cabinet 'media1.cab' does not contain any files. If this installation > contains no files, this warning can likely be safely ignored. Otherwise, > please add files to the cabinet or remove it. > ========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ========== > > I see them: -d"WiXProductName=BeamGage Standard" -dWiXProductVersion= > > Note that $(WiXVersion) in my project file so I would expect not to see a > value on the command line. > I assume you are defining the WiXVersion property in your project. > > I ran msbuild on the command line (I'll only show the output for the candle > task for brevity): > > msbuild .\WixProject1.sln /t:rebuild /v:detailed > > Task "Candle" > Command: > C:\Program Files\Windows Installer XML v3\bin\candle.exe -dDebug - > d"WixProductName=BeamGage Standard" -dWiXProductVersion= - > d"DevEnvDir=c:\Program Files\Microsoft Visual Studio > 9.0\Common7\IDE" -dSolutionDir=C:\code\WixProject1\ -dSolutionExt=.sln - > dSolutionFileName=WixProject1.sln -dSolutionName=WixProject1 - > dSolutionPath=C:\code\WixProject1\WixProjec > t1.sln -dConfiguration=Debug -dOutDir=bin\Debug\ -dPlatform=x86 - > dProjectDir=C:\code\WixProject1\WixProject1\ -dProjectExt=.wixproj - > dProjectFileName=WixProject1.wixproj -dProje > ctName=WixProject1 - > dProjectPath=C:\code\WixProject1\WixProject1\WixProject1.wixproj - > dTargetDir=C:\code\WixProject1\WixProject1\bin\Debug\ -dTargetExt=.msi - > dTargetFileName=Wix > Project1.msi -dTargetName=WixProject1 - > dTargetPath=C:\code\WixProject1\WixProject1\bin\Debug\WixProject1.msi -out > obj\Debug\Product.wixobj -arch x86 Product.wxs > Microsoft (R) Windows Installer Xml Compiler version 3.0.5419.0 > Copyright (C) Microsoft Corporation. All rights reserved. > > Product.wxs > Done executing task "Candle". > > msbuild .\WixProject1.sln /t:rebuild /v:detailed /p:Configuration=Release > > Task "Candle" > Command: > C:\Program Files\Windows Installer XML v3\bin\candle.exe - > d"WixProductName=BeamGage Standard" -dWiXProductVersion= - > d"DevEnvDir=c:\Program Files\Microsoft Visual Studio 9.0\Comm > on7\IDE" -dSolutionDir=C:\code\WixProject1\ -dSolutionExt=.sln - > dSolutionFileName=WixProject1.sln -dSolutionName=WixProject1 - > dSolutionPath=C:\code\WixProject1\WixProject1.sln - > dConfiguration=Release -dOutDir=bin\Release\ -dPlatform=x86 - > dProjectDir=C:\code\WixProject1\WixProject1\ -dProjectExt=.wixproj - > dProjectFileName=WixProject1.wixproj -dProjectNa > me=WixProject1 - > dProjectPath=C:\code\WixProject1\WixProject1\WixProject1.wixproj - > dTargetDir=C:\code\WixProject1\WixProject1\bin\Release\ -dTargetExt=.msi - > dTargetFileName=WixPr > oject1.msi -dTargetName=WixProject1 - > dTargetPath=C:\code\WixProject1\WixProject1\bin\Release\WixProject1.msi -out > obj\Release\Product.wixobj -arch x86 Product.wxs > Microsoft (R) Windows Installer Xml Compiler version 3.0.5419.0 > Copyright (C) Microsoft Corporation. All rights reserved. > > Product.wxs > Done executing task "Candle". > > I see them here too: -d"WiXProductName=BeamGage Standard" -dWiXProductVersion= > > That's the behavior I expected. Am I missing something? > > Edwin G. Castro > Software Developer - Staff > Electronic Banking Services > Fiserv > Office: 503-746-0643 > Fax: 503-617-0291 > www.fiserv.com > Please consider the environment before printing this e-mail > > > -----Original Message----- > > From: Kurt Jensen [mailto:kurt.jen...@ophir-spiricon.com] > > Sent: Wednesday, May 19, 2010 9:11 AM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] msbuild command line parameters > > > > Repro is simple. From a default wixproj created in VS2008, I added the > > following > > > > <PropertyGroup> > > > > <WixToolPath>$(MSBuildProjectDirectory)\..\..\..\Installations\WiX\Wind > > ows Installer XML v3\bin\</WixToolPath> > > <WixTargetsPath>$(WixToolPath)Wix.targets</WixTargetsPath> > > <WixTasksPath>$(WixToolPath)wixtasks.dll</WixTasksPath> > > <IncludeSearchPaths> > > </IncludeSearchPaths> > > </PropertyGroup> > > > > and > > > > <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == > > 'Release|x86' "> > > <OutputPath>bin\$(Configuration)\</OutputPath> > > > > <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath> > > <DefineConstants> WiXProductName=&quot;BeamGage > > Standard&quot;; WiXProductVersion=$(WiXVersion);</DefineConstants> > > </PropertyGroup> > > > > I am using WiX v3.0. When I run this wixproj under msbuild the > > DefineConstants are NOT included on the command line to candle. I have > > verified that the IntermediateOutputPath is processed. > > > > That was it. I was building our solution including a similar, previous > > wixproj that did not require the DefineConstants. > > > > > > I am at a dead end. I do not know what to do. Where else can I go for > > help? > > > > > > > > -----Original Message----- > > From: Castro, Edwin G. (Hillsboro) [mailto:edwin.cas...@fiserv.com] > > Sent: Wednesday, May 19, 2010 9:39 AM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] msbuild command line parameters > > > > I've successfully used DefineConstants before. I used it to provide > > external paths to locations I was harvesting. Of course, a repo would > > be nice. > > > > Edwin G. Castro > > Software Developer - Staff > > Electronic Banking Services > > Fiserv > > Office: 503-746-0643 > > Fax: 503-617-0291 > > www.fiserv.com > > Please consider the environment before printing this e-mail > > > > > > > -----Original Message----- > > > From: Kurt Jensen [mailto:kurt.jen...@ophir-spiricon.com] > > > Sent: Wednesday, May 19, 2010 7:30 AM > > > To: General discussion for Windows Installer XML toolset. > > > Subject: Re: [WiX-users] msbuild command line parameters > > > > > > I'm having trouble getting the build to behave right now... > > > > > > > > > In the mean time, this was the source I was following > > > > > > http://www.ageektrapped.com/blog/setting-properties-for-wix-in- > > msbuild/ > > > > > > I am assuming that this worked at the time it was written. But now > > it > > > does not work? > > > > > > > > > > > > -----Original Message----- > > > From: Kurt Jensen > > > Sent: Tuesday, May 18, 2010 2:41 PM > > > To: 'General discussion for Windows Installer XML toolset.' > > > Subject: RE: [WiX-users] msbuild command line parameters > > > > > > I'll try. It is being built under VS2008 and TFS2008. > > > > > > > > > -----Original Message----- > > > From: Castro, Edwin G. (Hillsboro) [mailto:edwin.cas...@fiserv.com] > > > Sent: Tuesday, May 18, 2010 2:25 PM > > > To: General discussion for Windows Installer XML toolset. > > > Subject: Re: [WiX-users] msbuild command line parameters > > > > > > Can you make a minimal *.wixproj that reproduces the problem? > > > I don't see anything obvious in the information you've already > > shared. > > > I just looked through the wix.targets and wix2010.targets files in > > case > > > something is happening there that would account for what you are > > seeing > > > but didn't find anything obvious either. > > > > > > Edwin G. Castro > > > Software Developer - Staff > > > Electronic Banking Services > > > Fiserv > > > Office: 503-746-0643 > > > Fax: 503-617-0291 > > > www.fiserv.com > > > Please consider the environment before printing this e-mail > > > > > > > > > > -----Original Message----- > > > > From: Kurt Jensen [mailto:kurt.jen...@ophir-spiricon.com] > > > > Sent: Tuesday, May 18, 2010 1:08 PM > > > > To: General discussion for Windows Installer XML toolset. > > > > Subject: Re: [WiX-users] msbuild command line parameters > > > > > > > > Good idea but still not appearing in the build log. > > > > > > > > Any more ideas out there? > > > > > > > > -----Original Message----- > > > > From: Blair [mailto:os...@live.com] > > > > Sent: Monday, May 17, 2010 10:14 PM > > > > To: 'General discussion for Windows Installer XML toolset.' > > > > Subject: Re: [WiX-users] msbuild command line parameters > > > > > > > > I haven't tested it, but I wonder if the whitespace is causing > > > > problems. > > > > > > > > What happens if you try: > > > > <DefineConstants>WiXProductName="BeamGage > > > > > > Professional";WiXProductVersion=$(WiXVersion)</DefineConstants> > > > > Or: > > > > <DefineConstants>"WiXProductName=BeamGage > > > > > > Professional";WiXProductVersion=$(WiXVersion)</DefineConstants> > > > > ? > > > > > > > > -----Original Message----- > > > > From: Kurt Jensen [mailto:kurt.jen...@ophir-spiricon.com] > > > > Sent: Monday, May 17, 2010 3:48 PM > > > > To: General discussion for Windows Installer XML toolset. > > > > Subject: Re: [WiX-users] msbuild command line parameters > > > > > > > > The PropertyGroup code is as follows: > > > > > > > > <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == > > > > 'Release|x86' "> > > > > <OutputPath>bin\$(Configuration)\</OutputPath> > > > > > > > > > > > > > <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath> > > > > <DefineConstants>WiXProductName=BeamGage > > > > Professional;WiXProductVersion=$(WiXVersion);</DefineConstants> > > > > </PropertyGroup> > > > > > > > > I changed <IntermediateOutputPath> to "obj\IntermediateOutputPath". > > > > The > > > > command line in the build log now specifies "-out > > > > obj\IntermediateOutputPath\module.wixobj". That proves that the > > > > PropertyGroup containing DefineConstants is being executed. > > > > > > > > I should be seeing "-dWixProductName=" and "-dWixProductVersion=" > > on > > > > the > > > > command line. > > > > > > > > Any idea why the DefineConstants is not being passed to candle? > > > > > > > > > > > > -----Original Message----- > > > > From: Kurt Jensen [mailto:kurt.jen...@ophir-spiricon.com] > > > > Sent: Monday, May 17, 2010 3:05 PM > > > > To: wix-users@lists.sourceforge.net > > > > Subject: [WiX-users] msbuild command line parameters > > > > > > > > I'm trying to build my wixproj in msbuild. The solution > > > > ConfigurationToBuild is "Release|Any CPU". Inside of my > > > configuration > > > > the wixproj is built as "Release|x86". > > > > > > > > > > > > > > > > In my wixproj I have a 'Release|x86' PropertyGroup that includes > > > > <DefineConstants>. But none of the DefineConstants are being > > > included > > > > on the command line to candle during the build. The PropertyGroup > > > and > > > > DefineConstants work fine in the IDE. In the build log I verified > > > that > > > > the command line contains -dConfiguration=Release and - > > > dPlatform=x86. > > > > > > > > > > > > > > > > Any idea how to get the wixproj DefineConstants passed to candle in > > > > msbuild? > > > > > > > > > > > > > > > > Kurt Jensen > > > > > > > > > > > > > > > > > ********************************************************************** > > > > This email and any files transmitted with it are confidential and > > > > intended solely for the use of the individual or entity to whom > > they > > > > are addressed. If you have received this email in error please > > notify > > > > the system manager. > > > > > > > > This footnote also confirms that this email message has been swept > > by > > > > MIMEsweeper for the presence of computer viruses. > > > > > > > > www.clearswift.com > > > > > > > > > ********************************************************************** > > > > > > > > > > > > ------------------------------------------------------------------- > > -- > > > -- > > > > - > > > > ------ > > > > > > > > _______________________________________________ > > > > WiX-users mailing list > > > > WiX-users@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > ------------------------------------------------------------------- > > -- > > > -- > > > > - > > > > ---- > > > > -- > > > > > > > > _______________________________________________ > > > > WiX-users mailing list > > > > WiX-users@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > > > > > ------------------------------------------------------------------- > > -- > > > -- > > > > - > > > > ------ > > > > > > > > _______________________________________________ > > > > WiX-users mailing list > > > > WiX-users@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > ------------------------------------------------------------------- > > -- > > > -- > > > > ------- > > > > > > > > _______________________________________________ > > > > WiX-users mailing list > > > > WiX-users@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > --------------------------------------------------------------------- > > -- > > > ------- > > > > > > _______________________________________________ > > > WiX-users mailing list > > > WiX-users@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > --------------------------------------------------------------------- > > -- > > > ------- > > > > > > _______________________________________________ > > > WiX-users mailing list > > > WiX-users@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wix-users > > ----------------------------------------------------------------------- > > ------- > > > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > ----------------------------------------------------------------------- > > ------- > > > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > ------------------------------------------------------------------------------ > > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
