I didn’t realise that the support effort is greater. I was thinking, coding all dissectors, including new and existing block types, as plugins seems like a good strategic direction. Surely beefing up the plugin framework would make Wireshark more extensible.
Anyway, I’ll re-code as built-in as suggested. From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Roland Knall Sent: 01 March 2018 10:27 To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Subject: Re: [Wireshark-dev] Dissector - plugin or built-in On Thu, Mar 1, 2018 at 11:22 AM, Graham Bloice <graham.blo...@trihedral.com<mailto:graham.blo...@trihedral.com>> wrote: On 1 March 2018 at 10:18, Roland Knall <rkn...@gmail.com<mailto:rkn...@gmail.com>> wrote: We do not have any other dissector within the code, which dissects blocktypes. Therefore I would not be so sure, that it will get rejected (in my book it definitely should not). But it most likely will get rejected as a plugin. Main reasons for built-in: - Easier to maintain - Best-practice approach - Would name it something like blocktype_trb.c or similar to distinguish from protocol-only dissectors Should we have a separate spot in the source tree for block type dissectors? I'm not sure if we will ever have lots, but should we keep epan/dissectors for "protocol" dissectors. Yeah, I was thinking along the same lines. like epan/blocktypes in comparison to epan/dissectors But we already have file-xxx dissectors in there. It would also make sense to have a epan/dissectors/packet, epan/dissectors/file, epan/dissectors/blocktype structure. What do you think? cheers Roland ______________________________________________________________________ This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ ______________________________________________________________________ This email has been scanned by the Symantec Email Security.cloud service. For more information please visit http://www.symanteccloud.com ______________________________________________________________________
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
