OK – I’ll take a look. Best regards…Paul
From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Pascal Quantin Sent: 01 March 2018 10:24 To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Subject: Re: [Wireshark-dev] Dissector - plugin or built-in Hi Paul, Le 1 mars 2018 10:47, "Paul Offord" <paul.off...@advance7.com<mailto:paul.off...@advance7.com>> a écrit : Hi Pascal, Thanks for your note regarding my change 26203 - https://code.wireshark.org/review/#/c/26203/ . You suggested that I submit it as a built-in dissector, not a plugin. I’m not keen for two reasons: * If it is rejected (and I have a feeling it will be), I’ll then have to rewrite it to offer as an optional plugin * I think adding it as a built-in dissector means changes to core Wireshark code Why do you think it should be a built-in dissector? Because : - we do not want to end with tons of plugins to support, that are heavier than built-in ones (startup time, more files to install,...) - our policy is to add new dissectors as built-in, not plugins (we are even converting some old plugins to built-in) Plugins are usually used for people not willing to submit code to Wireshark upstream. This is not your case, so you should really convert it to built-in (which is a 5 mn work or even less). Best regards, Pascal. ______________________________________________________________________ This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ ______________________________________________________________________ This email has been scanned by the Symantec Email Security.cloud service. For more information please visit http://www.symanteccloud.com ______________________________________________________________________
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
