On Mon, Mar 24, 2014 at 8:55 AM, <mman...@netscape.net> wrote: > I can't consistently view the code of patches submitted to Gerrit (the > Side-by-Side or Unified links). I've tried on IE8 and 9 as well as Firefox > v28 (all on Windows) and get the same consistently inconsistent results > (some patches work, some don't. Some files within a particular patch are > viewable, others aren't). The message I get on both browsers amounts to > "script too busy, want to stop it?". Selecting "no" just puts me in a > forever loop with that message.
I am also hitting this, see my comment at the bottom of [1]. In summary: the diff is computed locally in javascript, and seems to be worse than O(n) on the size of the underlying file; viewing the diff for any file >1k lines may be slow, but if you just let it run it will finish eventually. Avoid epan/enterprise-numbers and other files with 100k+ lines, they take many minutes to finish. I *think* it's a Gerrit bug, given that it seems to happen across many browsers. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=842623 > Any suggestions? Browser option I don't have enabled? Somehow upgrade > JavaScript version? I believe I have mostly "default" settings for all > browsers. > > And in a related issue (of annoyingness), typing "Enter" in the Gerrit > comments section results in a new line when I'm typing the comment, but not > when it's displayed (making some of my comments much harder to read). Is > this another "browser feature"? I haven't noticed it with other user > comments so I thought I must be doing something wrong. I believe it's parsed markdown/wiki style - single linebreaks are removed, but doubled ones are preserved. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
