Hmm, I'm not sure he meant that, especially since Richard's follow-up (http://www.wireshark.org/lists/wireshark-dev/200708/msg00432.html) indicated that he wanted me to send patches for each one.
I am basically going down the alphabet here, tediously looking for display filter fields that don't look right, then fixing them as I go. I'm only on 'C' at the moment, so this is going to take awhile before I'm done. Anyway, I guess I'm still confused as to what to do. Are you now saying to open a single bug and list all the dissectors that are affected, then go back and provide one big patch for all of them? I can tell you now that at the pace I'm going, I'll probably be interrupted or possibly even give up before I reach the end, so it's very possible that the single bug covering all dissectors will never be closed, at least not by patches provided by me. Perhaps a compromise? Like submitting a bug for each letter of the alphabet and list all dissectors affected beginning with that letter. This way, at most 26 bugs will be opened (apart from the ones I already opened)? Then patches can be attached one at a time as they're fixed and only when the last one is attached can the bug be reviewed for checkin? This will also mean that I can work on them in more manageable groups, and it will also let others know where I've left off in case someone else wants to assist with fixing these. - Chris -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Luis EG Ontanon Sent: Thursday, August 23, 2007 2:57 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1785]New:packet-dcerpc-atsvc.c display filter field problems I guess Guy thought you were just to report them, not to provide patches. I would go for a single patch. On 8/23/07, Maynard, Chris <[EMAIL PROTECTED]> wrote: > That directly contradicts what Guy Harris asked me to do earlier, namely > "I'd open bugs for each dissector (so we don't have to fix them all at > once to close the bug).". His thread in which he wrote that is here: > http://www.wireshark.org/lists/wireshark-dev/200708/msg00432.html > > Can you guys please let me know how I should continue? > > Thanks, > Chris > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Joerg Mayer > Sent: Thursday, August 23, 2007 2:37 PM > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1785] > New:packet-dcerpc-atsvc.c display filter field problems > > > Please try not to open a bug for each and every problem of this type: > > It makes it much more time intensive to review many many small patches > > than a few bigger patches. It's also more work with bugzilla. > > > > Thanks for your work though!!! > > > > ciao > > Joerg > > > ----------------------------------------- > This email may contain confidential and privileged material for the > sole use of the intended recipient(s). Any review, use, retention, > distribution or disclosure by others is strictly prohibited. If you > are not the intended recipient (or authorized to receive for the > recipient), please contact the sender by reply email and delete all > copies of this message. Also, email is susceptible to data > corruption, interception, tampering, unauthorized amendment and > viruses. We only send and receive emails on the basis that we are > not liable for any such corruption, interception, tampering, > amendment or viruses or any consequence thereof. > _______________________________________________ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > -- This information is top security. When you have read it, destroy yourself. -- Marshall McLuhan _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
