That's great. Now that I've demonstrated to our management that we can get changes into the Wireshark code (so long as they're useful to everybody), I'll be sitting down with the guys who use Wireshark a lot here and looking at the Wireshark wishlist; hopefully I'll be given the time to do more stuff!
Quite right about the GNU library - as I was developing on Win32 it wasn't true even for me! If I read things correctly my assumption is true for (at least) all POSIX compliant systems and for Win32. If there is a platform out there that has a non-zero time_t value for epoch I would be surprised. Doug -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Stephen Fisher Sent: 05 December 2006 03:28 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Patch adding option to display time as seconds(and fractions) since epoch On Mon, Dec 04, 2006 at 03:59:09PM -0000, Douglas Pratley wrote: > Corrected patch; epan/column.c and epan/column_utils.c were not > included. This one has now been properly tested against a clean > checkout of today's code. > > - New menu option available under view\time display format > - New sub-option (e) to -t switch for both wireshark and tshark > - Extended recent settings code to handle new value > - Did NOT add new explicit epoch time column Looks good! I have committed your changes as SVN revision 20040 and added you to the authors list - thanks taking the time to implement this :). I made a few minor changes to formatting to line up tabs, spacing, etc. I removed the comment about being linked against the GNU C library as that's only the case on (Linux?) and not other systems we support, such as the BSDs. Anyway, time_t is defined so that 0 = epoch (Jan 1 1970 00:00:00) on any standard system so it is ok in your code. I added the new e option to -t to the wireshark.pod / tshark.pod (for man pages and HTML help pages) and the User's Guide (docbook/wsug_src/WSUG_chapter_customize.xml). Finally, I removed two unused variables from col_set_epoch_time in column-utils.c to squelch compiler warnings. Steve _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately. Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies. Detica Limited is registered in England under No: 1337451. Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England. _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
