Hi Alistair,
This could be a good option. libxslt should properly be non-optional
since msxml3 relys on it.
From the Makefile.in, its appears to have linked to libxslt for quite some
time,
but was never an issue since it was never used.
Francois Gouget raised this bug,
http://bugs.winehq.org/show_bug.cgi?id=13035
that libslt should be dynamic, which could be another option.
I think in my case the problem is a bit different; I have the library -
what I don't have are the development headers. Thus the linking all
works, but HAVE_LIBXSLT is not defined, so the transform function
ends up as a stub, and goes on to fail.
And I still don't know a right answer.
The attached patch is one approach - skip the tests in this case.
Does this seem like a reasonable approach to folks?
Cheers,
Jeremy
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index bd45a77..1800531 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -3242,11 +3242,15 @@ static void test_testTransforms(void)
ok(hr == S_OK, "ret %08x\n", hr );
if(hr == S_OK)
{
+#ifdef HAVE_LIBXSLT
BSTR bOut;
hr = IXMLDOMDocument_transformNode(doc, pNode, &bOut);
ok(hr == S_OK, "ret %08x\n", hr );
ok( compareIgnoreReturns( bOut, _bstr_(szTransformOutput)), "Stylesheet output not correct\n");
+#else
+ skip("Cannot test transformNode without libxslt headers\n");
+#endif
IXMLDOMNode_Release(pNode);
}
