"Wikinaut" posted a comment on MediaWiki.r110716. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110716#c30489
Commit summary for MediaWiki.r110716: Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value "nosuchaction" Wikinaut's comment: Thanks. As an additional argument for my patch, please see line 310 in https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/WikiArticleFeeds/WikiArticleFeeds.php?annotate=110721 if ( $action != 'feed' ) return true; So, an extension which consumes the UnknownAction hook must be able to read the original action value (even when this is "nosuchaction" for MW core). I am convinced, that all the https://www.mediawiki.org/wiki/Category:UnknownAction_extensions Extensions were probably broken between 1.18 and revision r110716 . _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
