"Wikinaut" posted a comment on MediaWiki.r110716.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110716#c30484

Commit summary for MediaWiki.r110716:

Please review carefully, I cannot see negative side effects from this patch. It 
gives extensions which use the (depreacted) UnknownAction hook a chance to see 
the original action= value. This fixes bug 34203 and bug 34161 UnknownAction 
hook problem: the hook must pass the unknown action to the callee and not the 
value "nosuchaction"

Wikinaut's comment:

I have no idea when this broke (in Wiki.php). Only those extensions are(were) 
affected which use the hook 

https://www.mediawiki.org/wiki/Category:UnknownAction_extensions

For example, I debugged and fixed 
https://www.mediawiki.org/wiki/Extension:WikiArticleFeeds and found the problem 
with $act. This extension was working for years but stopped working when I 
upgraded to trunk version.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to