"Petrb" posted a comment on MediaWiki.r107297.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107297#c28524

Commit summary for MediaWiki.r107297:

merged some things commited in past
simplified some stuff
fixed several security issues
moved one class from core

Petrb's comment:

string text, message are declared before while because of performance reasons, 
I don't like the idea that garbage collector will need to clean up the strings 
generated from every loop, however if you think that it's wrong feel free to 
put it back

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to