"Reedy" changed the status of MediaWiki.r106280 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106280#c28522
Old Status: deferred > New Status: fixme Commit summary for MediaWiki.r106280: * Made FileBackendMultiWrite substitute the backend name portion of storage paths as needed since each backend has it's own name (registration disallowes duplicate names). * Refactored doOperations() code duplication into a FileBackendBase::attemptOperations() function. Removed code that reset $predicates from FileBackendMultiWrite as the paths include the backend name already, so there is no ambiguity. * Made FileBackend::doOperations() use shared locks where possible (some lock managers may interpret LOCK_UW as LOCK_EX instead of LOCK_SH) * Removed getFileHash() comment (function removed). * Renamed FSFile::sha1Base36() -> FSFile::getSha1Base36() Reedy's comment: Marking fixme as this is now an issue in core. Line 208 of FileBackendMultiWrite.php uses a undefined $backend variable _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
