"GrafZahl" posted a comment on MediaWiki.r107277. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107277#c28523
Commit summary for MediaWiki.r107277: Simplified profiling by wrapping wfProfileIn/Out calls in a class. Profile all methods that call wfShellExec(), explicitly or implicitly. GrafZahl's comment: I had already tested it with my private Mediawiki installation with profile debugging on, and it worked. Doesn't mean much of course. Is there a PHP standard document, such as C99 for C? Given that the basic construct pops up in other new MediaWiki code too, the general question seems to be worthwhile pondering. Essentially, your fear is that the PHP destructors are not destructors at all, but finalizers, right? What's the best place to pose this question to a wider auditorium? wikitech-l? Some PHP forum? What do you mean by "it's left to function scope, ie sometime after the function call has ended"? The overhead required to restore the previous stack frame? Is that measurable/important? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
