"Reedy" posted a comment on MediaWiki.r107277. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107277#c28521
Commit summary for MediaWiki.r107277: Simplified profiling by wrapping wfProfileIn/Out calls in a class. Profile all methods that call wfShellExec(), explicitly or implicitly. Reedy's comment: Hmm. New classes added by Aaron in the filebackend rewrite.... I've seen similar wording on other languages, where the garbage collector will effectively "do it when it wants to", even with tighter scoping. As you're not doing it explicitly ( "$prof = null;" ), it's left to function scope, ie sometime after the function call has ended Just seems like more question-ability for little simplification Test it, and see? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
