"Catrope" changed the status of MediaWiki.r103490 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103490#c26751
Old Status: deferred > New Status: ok Commit summary for MediaWiki.r103490: Fixed passing global offset to emit event, preventing render from re-rendering because it thought the render-from point was well past it's length Catrope's comment: This is OK, but it does cause double traversal because both getNodeFromOffset() and getOffsetFromNode() are called. We should have a function that returns both the node and the offset within that node, or something like that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
