"Catrope" changed the status of MediaWiki.r104687 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104687#c26750
Old Status: new > New Status: fixme Commit summary for MediaWiki.r104687: Use database to track uploaded chunks and concatenate at the end. with i18n documentation dont break phpunit follow up r93720 Catrope's comment: Breaks one test, see http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/3058/testReport/junit/%28root%29/DatabaseSqliteTest/testUpgrades/ <pre> DatabaseSqliteTest::testUpgrades Mismatching columns for table "uploadstash" upgrading from 1.15 to 1.19alpha Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( - [0] => us_chunk_inx - [1] => us_id - [2] => us_image_bits - [3] => us_image_height - [4] => us_image_width - [5] => us_key - [6] => us_media_type - [7] => us_mime - [8] => us_orig_path - [9] => us_path - [10] => us_sha1 - [11] => us_size - [12] => us_source_type - [13] => us_status - [14] => us_timestamp - [15] => us_user + [0] => us_id + [1] => us_image_bits + [2] => us_image_height + [3] => us_image_width + [4] => us_key + [5] => us_media_type + [6] => us_mime + [7] => us_orig_path + [8] => us_path + [9] => us_sha1 + [10] => us_size + [11] => us_source_type + [12] => us_status + [13] => us_timestamp + [14] => us_user ) /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/db/DatabaseSqliteTest.php:218 /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:68 /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44 /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
