Title: [139828] trunk/Source/WebCore
- Revision
- 139828
- Author
- charles....@torchmobile.com.cn
- Date
- 2013-01-15 19:53:35 -0800 (Tue, 15 Jan 2013)
Log Message
[BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect
https://bugs.webkit.org/show_bug.cgi?id=106896
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson and John Griggs.
No new tests,clean up code which is not used anymore.
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawHolePunchRect):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderingResults):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139827 => 139828)
--- trunk/Source/WebCore/ChangeLog 2013-01-16 03:44:37 UTC (rev 139827)
+++ trunk/Source/WebCore/ChangeLog 2013-01-16 03:53:35 UTC (rev 139828)
@@ -1,5 +1,20 @@
2013-01-15 Charles Wei <charles....@torchmobile.com.cn>
+ [BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect
+ https://bugs.webkit.org/show_bug.cgi?id=106896
+
+ Reviewed by George Staikos.
+ Internally reviewed by Arvid Nilsson and John Griggs.
+
+ No new tests,clean up code which is not used anymore.
+
+ * platform/graphics/blackberry/LayerRenderer.cpp:
+ (WebCore::LayerRenderer::drawHolePunchRect):
+ * platform/graphics/blackberry/LayerRenderer.h:
+ (LayerRenderingResults):
+
+2013-01-15 Charles Wei <charles....@torchmobile.com.cn>
+
Fullscreen element should not share styles with it's siblings.
https://bugs.webkit.org/show_bug.cgi?id=106888
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp (139827 => 139828)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp 2013-01-16 03:44:37 UTC (rev 139827)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp 2013-01-16 03:53:35 UTC (rev 139828)
@@ -612,9 +612,6 @@
glDrawArrays(GL_TRIANGLE_FAN, 0, 4);
checkGLError();
glBlendFunc(GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
-
- IntRect holeWC = toWebKitWindowCoordinates(hole.boundingBox());
- m_lastRenderingResults.addHolePunchRect(holeWC);
}
void LayerRenderer::prepareFrameRecursive(LayerCompositingThread* layer, double animationTime, bool isContextCurrent)
@@ -1198,24 +1195,6 @@
return true;
}
-IntRect LayerRenderingResults::holePunchRect(unsigned index) const
-{
- if (index >= m_holePunchRects.size())
- return IntRect();
-
- return m_holePunchRects.at(index);
-}
-
-void LayerRenderingResults::addHolePunchRect(const IntRect& rect)
-{
-#if DEBUG_CLIPPING
- printf("LayerRenderingResults::addHolePunchRect (%d,%d %dx%d)\n", rect.x(), rect.y(), rect.width(), rect.height());
- fflush(stdout);
-#endif
- if (!rect.isEmpty())
- m_holePunchRects.append(rect);
-}
-
void LayerRenderingResults::addDirtyRect(const IntRect& rect)
{
IntRect dirtyUnion[NumberOfDirtyRects];
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h (139827 => 139828)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h 2013-01-16 03:44:37 UTC (rev 139827)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h 2013-01-16 03:53:35 UTC (rev 139828)
@@ -56,10 +56,6 @@
public:
LayerRenderingResults() : wasEmpty(true), needsAnimationFrame(false) { }
- void addHolePunchRect(const IntRect&);
- IntRect holePunchRect(size_t index) const;
- size_t holePunchRectSize() { return m_holePunchRects.size(); }
-
static const int NumberOfDirtyRects = 3;
const IntRect& dirtyRect(int i) const { return m_dirtyRects[i]; }
void addDirtyRect(const IntRect& dirtyRect);
@@ -72,7 +68,6 @@
bool needsAnimationFrame;
private:
- Vector<IntRect> m_holePunchRects; // Rects are in compositing surface coordinates.
IntRect m_dirtyRects[NumberOfDirtyRects];
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
