Title: [139827] trunk/Tools
- Revision
- 139827
- Author
- [email protected]
- Date
- 2013-01-15 19:44:37 -0800 (Tue, 15 Jan 2013)
Log Message
webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974
Reviewed by Ryosuke Niwa.
I forgot to stub out the call to check to ensure that the ports were
available, so this test could fail if something was listening on 8000 or
8443 on the machine.
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139826 => 139827)
--- trunk/Tools/ChangeLog 2013-01-16 03:20:01 UTC (rev 139826)
+++ trunk/Tools/ChangeLog 2013-01-16 03:44:37 UTC (rev 139827)
@@ -1,3 +1,17 @@
+2013-01-15 Dirk Pranke <[email protected]>
+
+ webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=106974
+
+ Reviewed by Ryosuke Niwa.
+
+ I forgot to stub out the call to check to ensure that the ports were
+ available, so this test could fail if something was listening on 8000 or
+ 8443 on the machine.
+
+ * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
+ (TestHttpServer.test_win32_start_and_stop):
+
2013-01-15 Levi Weintraub <[email protected]>
Unreviewed, rolling out r139792.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py (139826 => 139827)
--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py 2013-01-16 03:20:01 UTC (rev 139826)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py 2013-01-16 03:44:37 UTC (rev 139827)
@@ -78,6 +78,7 @@
additional_dirs={
"/mock/one-additional-dir": "/mock-checkout/one-additional-dir",
"/mock/another-additional-dir": "/mock-checkout/one-additional-dir"})
+ server._check_that_all_ports_are_available = lambda: True
server._is_server_running_on_all_ports = lambda: True
server.start()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
