Title: [139221] trunk/LayoutTests
Revision
139221
Author
o...@chromium.org
Date
2013-01-09 12:24:03 -0800 (Wed, 09 Jan 2013)

Log Message

fast/forms/min-content-form-controls.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=106482

Reviewed by Eric Seidel.

The text dump for some form controls (menulists?) has different whitespace
output on different platforms. Remove the form controls to avoid adding
platform-specific expectations for this test.

* fast/forms/min-content-form-controls-expected.txt:
* fast/forms/min-content-form-controls.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (139220 => 139221)


--- trunk/LayoutTests/ChangeLog	2013-01-09 20:19:47 UTC (rev 139220)
+++ trunk/LayoutTests/ChangeLog	2013-01-09 20:24:03 UTC (rev 139221)
@@ -1,3 +1,18 @@
+2013-01-09  Ojan Vafai  <o...@chromium.org>
+
+        fast/forms/min-content-form-controls.html fails on some platforms
+        https://bugs.webkit.org/show_bug.cgi?id=106482
+
+        Reviewed by Eric Seidel.
+
+        The text dump for some form controls (menulists?) has different whitespace
+        output on different platforms. Remove the form controls to avoid adding
+        platform-specific expectations for this test.
+
+        * fast/forms/min-content-form-controls-expected.txt:
+        * fast/forms/min-content-form-controls.html:
+        * platform/mac/TestExpectations:
+
 2013-01-09  Michael Pruett  <mich...@68k.org>
 
         IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html

Modified: trunk/LayoutTests/fast/forms/min-content-form-controls-expected.txt (139220 => 139221)


--- trunk/LayoutTests/fast/forms/min-content-form-controls-expected.txt	2013-01-09 20:19:47 UTC (rev 139220)
+++ trunk/LayoutTests/fast/forms/min-content-form-controls-expected.txt	2013-01-09 20:24:03 UTC (rev 139221)
@@ -8,4 +8,4 @@
 TEST COMPLETE
 The form controls of the same type below should be the same width.
 
-             
+

Modified: trunk/LayoutTests/fast/forms/min-content-form-controls.html (139220 => 139221)


--- trunk/LayoutTests/fast/forms/min-content-form-controls.html	2013-01-09 20:19:47 UTC (rev 139220)
+++ trunk/LayoutTests/fast/forms/min-content-form-controls.html	2013-01-09 20:24:03 UTC (rev 139221)
@@ -31,6 +31,19 @@
 var ids = ['text', 'file', 'range', 'select', 'multiple'];
 ids.forEach(function(id) {
     shouldBe('document.getElementById("' + id + '-a").offsetWidth', 'document.getElementById("' + id + '-b").offsetWidth');
-})
+});
+
+function remove(id) {
+    var node = document.getElementById(id);
+    node.parentNode.removeChild(node);
+}
+
+if (window.testRunner) {
+    // Remove these elements since some of the text dumps are different platforms.
+    ids.forEach(function(id) {
+        remove(id + '-a');
+        remove(id + '-b');
+    });
+}
 </script>
 <script src=""

Modified: trunk/LayoutTests/platform/mac/TestExpectations (139220 => 139221)


--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 20:19:47 UTC (rev 139220)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 20:24:03 UTC (rev 139221)
@@ -1244,10 +1244,6 @@
 
 webkit.org/b/105932 [ MountainLion Debug ] http/tests/inspector/resource-har-pages.html [ Crash ]
 
-# Need to see this run on the bots to see what's wrong. The code change in 
-# https://bugs.webkit.org/show_bug.cgi?id=106389 is only touching cross-platform code.
-Bug(ojan) fast/forms/min-content-form-controls.html [ Failure ]
-
 webkit.org/b/105986 [ Debug ] transitions/hang-with-bad-transition-list.html [ Pass Crash ]
 webkit.org/b/105986 [ Debug ] svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html [ Pass Crash ]
 webkit.org/b/105986 [ Debug ] svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html [ Pass Crash ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to