Title: [139219] trunk/LayoutTests
- Revision
- 139219
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-09 12:12:02 -0800 (Wed, 09 Jan 2013)
Log Message
IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
https://bugs.webkit.org/show_bug.cgi?id=106472
Patch by Michael Pruett <mich...@68k.org> on 2013-01-09
Reviewed by Tony Chang.
The tests which verify that JSON.stringify() throws an exception
for cyclic objects produce different error messages on JSC and
V8 and do nothing to test IndexedDB functionality. These tests
should be removed.
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/resources/key-type-array.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139218 => 139219)
--- trunk/LayoutTests/ChangeLog 2013-01-09 20:08:32 UTC (rev 139218)
+++ trunk/LayoutTests/ChangeLog 2013-01-09 20:12:02 UTC (rev 139219)
@@ -1,3 +1,18 @@
+2013-01-09 Michael Pruett <mich...@68k.org>
+
+ IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
+ https://bugs.webkit.org/show_bug.cgi?id=106472
+
+ Reviewed by Tony Chang.
+
+ The tests which verify that JSON.stringify() throws an exception
+ for cyclic objects produce different error messages on JSC and
+ V8 and do nothing to test IndexedDB functionality. These tests
+ should be removed.
+
+ * storage/indexeddb/key-type-array-expected.txt:
+ * storage/indexeddb/resources/key-type-array.js:
+
2013-01-08 Ojan Vafai <o...@chromium.org>
min-content gets the wrong value if min-width is set on some form controls
Modified: trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt (139218 => 139219)
--- trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt 2013-01-09 20:08:32 UTC (rev 139218)
+++ trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt 2013-01-09 20:12:02 UTC (rev 139219)
@@ -158,17 +158,12 @@
array that contains itself: array = [ array ]
cyclic_array = []; cyclic_array.push(cyclic_array)
-PASS JSON.stringify(cyclic_array) threw exception TypeError: Converting circular structure to JSON.
array that contains itself, one level down: array = [ [ array ] ]
cyclic_array2 = []; cyclic_array2.push([cyclic_array2])
-PASS JSON.stringify(cyclic_array2) threw exception TypeError: Converting circular structure to JSON.
array that contains itself, not as first element: array = [1, 'b', [], array]
cyclic_array3 = [1, 'b', []]; cyclic_array3.push(cyclic_array3)
-PASS JSON.stringify(cyclic_array3) threw exception TypeError: Converting circular structure to JSON.
-
array that contains array that contains itself
cyclic_array4 = [cyclic_array];
-PASS JSON.stringify(cyclic_array4) threw exception TypeError: Converting circular structure to JSON.
testing invalid array key: [ void 0 ]
Expecting exception from store.put('value', [ void 0 ]);
Modified: trunk/LayoutTests/storage/indexeddb/resources/key-type-array.js (139218 => 139219)
--- trunk/LayoutTests/storage/indexeddb/resources/key-type-array.js 2013-01-09 20:08:32 UTC (rev 139218)
+++ trunk/LayoutTests/storage/indexeddb/resources/key-type-array.js 2013-01-09 20:12:02 UTC (rev 139219)
@@ -105,20 +105,15 @@
debug("array that contains itself: array = [ array ]");
evalAndLog("cyclic_array = []; cyclic_array.push(cyclic_array)");
- shouldThrow("JSON.stringify(cyclic_array)");
debug("array that contains itself, one level down: array = [ [ array ] ]");
evalAndLog("cyclic_array2 = []; cyclic_array2.push([cyclic_array2])");
- shouldThrow("JSON.stringify(cyclic_array2)");
debug("array that contains itself, not as first element: array = [1, 'b', [], array]");
evalAndLog("cyclic_array3 = [1, 'b', []]; cyclic_array3.push(cyclic_array3)");
- shouldThrow("JSON.stringify(cyclic_array3)");
- debug("");
debug("array that contains array that contains itself");
evalAndLog("cyclic_array4 = [cyclic_array];");
- shouldThrow("JSON.stringify(cyclic_array4)");
debug("");
var invalidKeys = [
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
