Title: [135327] trunk/Source/WebCore
- Revision
- 135327
- Author
- rn...@webkit.org
- Date
- 2012-11-20 16:07:02 -0800 (Tue, 20 Nov 2012)
Log Message
Fix another typo. I need to checking that type() != NodeListCollectionType,
not that type() >= FirstNodeCollectionType.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::invalidateCache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135326 => 135327)
--- trunk/Source/WebCore/ChangeLog 2012-11-20 23:56:48 UTC (rev 135326)
+++ trunk/Source/WebCore/ChangeLog 2012-11-21 00:07:02 UTC (rev 135327)
@@ -1,3 +1,13 @@
+2012-11-20 Ryosuke Niwa <rn...@webkit.org>
+
+ Fix another typo. I need to checking that type() != NodeListCollectionType,
+ not that type() >= FirstNodeCollectionType.
+
+ * dom/DynamicNodeList.cpp:
+ (WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):
+ * dom/DynamicNodeList.h:
+ (WebCore::DynamicNodeListCacheBase::invalidateCache):
+
2012-11-20 Michael Pruett <mich...@68k.org>
[V8] Pass ScriptState::current() to functions marked with CallWith=ScriptState
Modified: trunk/Source/WebCore/dom/DynamicNodeList.cpp (135326 => 135327)
--- trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-11-20 23:56:48 UTC (rev 135326)
+++ trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-11-21 00:07:02 UTC (rev 135327)
@@ -73,7 +73,7 @@
void DynamicNodeListCacheBase::invalidateIdNameCacheMaps() const
{
- ASSERT(isNodeCollectionType(type()));
+ ASSERT(type() != NodeListCollectionType);
const HTMLCollectionCacheBase* cacheBase = static_cast<const HTMLCollectionCacheBase*>(this);
cacheBase->m_idCache.clear();
cacheBase->m_nameCache.clear();
Modified: trunk/Source/WebCore/dom/DynamicNodeList.h (135326 => 135327)
--- trunk/Source/WebCore/dom/DynamicNodeList.h 2012-11-20 23:56:48 UTC (rev 135326)
+++ trunk/Source/WebCore/dom/DynamicNodeList.h 2012-11-21 00:07:02 UTC (rev 135327)
@@ -76,7 +76,7 @@
{
if (!attrName || shouldInvalidateTypeOnAttributeChange(invalidationType(), *attrName))
invalidateCache();
- else if (isNodeCollectionType(type()) && (*attrName == HTMLNames::idAttr || *attrName == HTMLNames::nameAttr))
+ else if (type() != NodeListCollectionType && (*attrName == HTMLNames::idAttr || *attrName == HTMLNames::nameAttr))
invalidateIdNameCacheMaps();
}
void invalidateCache() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
