Title: [135326] trunk/Tools
- Revision
- 135326
- Author
- o...@chromium.org
- Date
- 2012-11-20 15:56:48 -0800 (Tue, 20 Nov 2012)
Log Message
Remove special case for layout tests when builders fail to load
https://bugs.webkit.org/show_bug.cgi?id=102842
Reviewed by Tony Chang.
Now that we load only builders that actually run the given test
type, we can reliably show errors to the users because it
represents a broken bot.
* TestResultServer/static-dashboards/loader.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (135325 => 135326)
--- trunk/Tools/ChangeLog 2012-11-20 23:50:59 UTC (rev 135325)
+++ trunk/Tools/ChangeLog 2012-11-20 23:56:48 UTC (rev 135326)
@@ -1,3 +1,15 @@
+2012-11-20 Ojan Vafai <o...@chromium.org>
+
+ Remove special case for layout tests when builders fail to load
+ https://bugs.webkit.org/show_bug.cgi?id=102842
+
+ Reviewed by Tony Chang.
+
+ Now that we load only builders that actually run the given test
+ type, we can reliably show errors to the users because it
+ represents a broken bot.
+ * TestResultServer/static-dashboards/loader.js:
+
2012-11-15 Ojan Vafai <o...@chromium.org>
Generate a list of builders/test suites from the buildbot json
Modified: trunk/Tools/TestResultServer/static-dashboards/loader.js (135325 => 135326)
--- trunk/Tools/TestResultServer/static-dashboards/loader.js 2012-11-20 23:50:59 UTC (rev 135325)
+++ trunk/Tools/TestResultServer/static-dashboards/loader.js 2012-11-20 23:56:48 UTC (rev 135326)
@@ -160,16 +160,10 @@
},
_handleResultsFileLoadError: function(builderName)
{
- var error = 'Failed to load results file for ' + builderName + '.';
+ console.error('Failed to load results file for ' + builderName + '.');
- if (isLayoutTestResults()) {
- console.error(error);
- g_buildersThatFailedToLoad.push(builderName);
- } else {
- // Avoid to show error/warning messages for non-layout tests. We may be
- // checking the builders that are not running the tests.
- console.info('info:' + error);
- }
+ // FIXME: loader shouldn't depend on state defined in dashboard_base.js.
+ g_buildersThatFailedToLoad.push(builderName);
// Remove this builder from builders, so we don't try to use the
// data that isn't there.
Modified: trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js (135325 => 135326)
--- trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2012-11-20 23:50:59 UTC (rev 135325)
+++ trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2012-11-20 23:56:48 UTC (rev 135326)
@@ -107,3 +107,27 @@
loader.request = requestFunction;
}
});
+
+test('results file failing to load', 2, function() {
+ // FIXME: loader shouldn't depend on state defined in dashboard_base.js.
+ g_buildersThatFailedToLoad = [];
+ g_builders = {};
+
+ var resourceLoader = new loader.Loader();
+ var resourceLoadCount = 0;
+ resourceLoader._handleResourceLoad = function() {
+ resourceLoadCount++;
+ }
+
+ var builder1 = 'builder1';
+ g_builders[builder1] = true;
+ resourceLoader._handleResultsFileLoadError(builder1);
+
+ var builder2 = 'builder2';
+ g_builders[builder2] = true;
+ resourceLoader._handleResultsFileLoadError(builder2);
+
+ deepEqual(g_buildersThatFailedToLoad, [builder1, builder2]);
+ equal(resourceLoadCount, 2);
+
+})
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
