Title: [128198] trunk/Source/WebKit/blackberry
- Revision
- 128198
- Author
- mifen...@rim.com
- Date
- 2012-09-11 09:52:01 -0700 (Tue, 11 Sep 2012)
Log Message
[BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
https://bugs.webkit.org/show_bug.cgi?id=96394
Reviewed by Rob Buis.
Suppress the VKB notification when the touch event
is a spell checking request.
PR 192925.
Reviewed Internally by Gen Mak.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (128197 => 128198)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 16:48:14 UTC (rev 128197)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 16:52:01 UTC (rev 128198)
@@ -1,5 +1,22 @@
2012-09-11 Mike Fenton <mifen...@rim.com>
+ [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
+ https://bugs.webkit.org/show_bug.cgi?id=96394
+
+ Reviewed by Rob Buis.
+
+ Suppress the VKB notification when the touch event
+ is a spell checking request.
+
+ PR 192925.
+
+ Reviewed Internally by Gen Mak.
+
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
+2012-09-11 Mike Fenton <mifen...@rim.com>
+
[BlackBerry] Colour Dialog popup request should return proper state.
https://bugs.webkit.org/show_bug.cgi?id=96392
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (128197 => 128198)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-11 16:48:14 UTC (rev 128197)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-11 16:52:01 UTC (rev 128198)
@@ -235,8 +235,10 @@
// Apply any suppressed changes. This does not eliminate the need
// for the show after the handling of fat finger pressed as it may
- // have triggered a state change.
- m_webPage->m_inputHandler->processPendingKeyboardVisibilityChange();
+ // have triggered a state change. Leave the change suppressed if
+ // we are triggering spell check options.
+ if (!shouldRequestSpellCheckOptions)
+ m_webPage->m_inputHandler->processPendingKeyboardVisibilityChange();
if (shouldSuppressMouseDownOnTouchDown())
handleFatFingerPressed();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
