Title: [128197] trunk/Source/WebKit/blackberry
- Revision
- 128197
- Author
- mifen...@rim.com
- Date
- 2012-09-11 09:48:14 -0700 (Tue, 11 Sep 2012)
Log Message
[BlackBerry] Colour Dialog popup request should return proper state.
https://bugs.webkit.org/show_bug.cgi?id=96392
Reviewed by Rob Buis.
Return proper state from openColorPopup dependent on
whether the popup actually opened.
Reviewed Internally by Chris Hutten-Czapski
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openColorPopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (128196 => 128197)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 16:44:34 UTC (rev 128196)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 16:48:14 UTC (rev 128197)
@@ -1,3 +1,18 @@
+2012-09-11 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Colour Dialog popup request should return proper state.
+ https://bugs.webkit.org/show_bug.cgi?id=96392
+
+ Reviewed by Rob Buis.
+
+ Return proper state from openColorPopup dependent on
+ whether the popup actually opened.
+
+ Reviewed Internally by Chris Hutten-Czapski
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::openColorPopup):
+
2012-09-11 Nima Ghanavatian <nghanavat...@rim.com>
[BlackBerry] Take account for single words that exceed our client character limit
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (128196 => 128197)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-11 16:44:34 UTC (rev 128196)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-09-11 16:48:14 UTC (rev 128197)
@@ -1001,9 +1001,9 @@
// Check if popup already exists, close it if does.
m_webPage->m_page->chrome()->client()->closePagePopup(0);
+
ColorPickerClient* client = new ColorPickerClient(element->value(), m_webPage, element);
- m_webPage->m_page->chrome()->client()->openPagePopup(client, WebCore::IntRect());
- return true;
+ return m_webPage->m_page->chrome()->client()->openPagePopup(client, WebCore::IntRect());
}
void InputHandler::setInputValue(const WTF::String& value)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
