Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 050f431f75d666f23ea789cde99d4f13ae988184
https://github.com/WebKit/WebKit/commit/050f431f75d666f23ea789cde99d4f13ae988184
Author: Dominic Mazzoni <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
A
LayoutTests/accessibility/ios-simulator/media-captions-displayed-notification-expected.txt
A
LayoutTests/accessibility/ios-simulator/media-captions-displayed-notification.html
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/html/track/VTTCue.h
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp
M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
AX: Call MACaptionAppearanceDidDisplayCaptions to notify VoiceOver of video
captions as they're shown
https://bugs.webkit.org/show_bug.cgi?id=326732
rdar://189345812
Reviewed by Tyler Wilcock.
On iOS, VoiceOver has an optional feature to speak and/or braille video
captions as they're displayed. This works in native apps like Photos, Files,
and TV but not in Safari due to the way the media player is built in a
sandboxed process.
All that's needed is to call MACaptionAppearanceDidDisplayCaptions, a public
API, each time a caption is displayed. The rest is just plumbing.
Test: accessibility/ios-simulator/media-captions-displayed-notification.html
*
LayoutTests/accessibility/ios-simulator/media-captions-displayed-notification-expected.txt:
Added.
*
LayoutTests/accessibility/ios-simulator/media-captions-displayed-notification.html:
Added.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postCaptionsDisplayedNotification):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::displayedCaptionsDidChange):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::textTrackRemoveCue):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateDisplayedCaptionsForAccessibility):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h:
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::textWithoutMarkup):
(WebCore::VTTCue::getOrCreateWebVTTNodeTree):
(WebCore::VTTCue::getCueAsHTML):
(WebCore::VTTCue::createCueRenderingTree):
(WebCore::VTTCue::determineTextDirection):
(WebCore::VTTCue::createWebVTTNodeTree): Deleted.
* Source/WebCore/html/track/VTTCue.h:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::didDisplayCaptions const):
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp:
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didDisplayCaptions):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::didDisplayCaptions const):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didDisplayCaptions):
Canonical link: https://commits.webkit.org/323514@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
