Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 939a1d177ef963c4ac1f12fc19ae350b43cf9727
https://github.com/WebKit/WebKit/commit/939a1d177ef963c4ac1f12fc19ae350b43cf9727
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-08-12 (Wed, 12 Aug 2026)
Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.mm
M Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView.swift
M Source/WebKit/UIProcess/PDF/WKDefaultPDFHUDView.swift
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
Consolidate os_variant_is_basesystem() callers to a common WTF wrapper
https://bugs.webkit.org/show_bug.cgi?id=320072
rdar://182995822
Reviewed by Richard Robinson, Mike Wyrzykowski, Tim Horton, and Aditya Keerthi.
This is a second attempt at landing 318471@main, since the original
attempt was reverted after it broke macOS 26.4 Performance/ASAN builds.
`os_variant_is_basesystem("WebKit")` is found 5 times in the codebase.
Each caller needed to remember the `"WebKit"` magic string; the method
name is not necessarily the most intuitive, either.
This patch introduces a WTF::isInBaseSystem() wrapper, that lives in
wtf/cooca/RuntimeApplicationChecksCococa.h, providing callers an easy
and intuitive way to query if the application is running in macOS
BaseSystem.
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.mm:
(WTF::isInBaseSystem):
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.swift:
(isInRecoveryOS): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::m_flagsChangedEventMonitorTrackingArea):
* Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp:
(WebKit::WebModelPlayerProvider::isAvailable const):
(WebKit::isRunningInRecoveryOS): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::isInRecoveryOS): Deleted.
Canonical link: https://commits.webkit.org/319043@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
