Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 339108df2306ac05d435eb1a3cc4abc07abcfa83
https://github.com/WebKit/WebKit/commit/339108df2306ac05d435eb1a3cc4abc07abcfa83
Author: Alex Christensen <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M Source/WebCore/inspector/InspectorFrontendClient.h
M Source/WebCore/inspector/InspectorFrontendHost.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp
M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h
M Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h
M Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
Log Message:
-----------
Only include DiagnosticLoggingClient.h where necessary
https://bugs.webkit.org/show_bug.cgi?id=319105
rdar://181920760
Reviewed by David Kilzer.
Something mysterious was happening with cmake swift modules saying
DiagnosticLoggingClient
has a different definition in different modules. It was only from
DiagnosticLoggingClient.
Removing the include DiagnosticLoggingClient.h where possible fixes the build
failure for me.
* Source/WebCore/inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::logDiagnosticEvent):
* Source/WebCore/inspector/InspectorFrontendHost.cpp:
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
* Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:
* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h:
* Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:
Canonical link: https://commits.webkit.org/316916@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
